Curl re-using connections with wrong client cert
Posted on 30 November -0001
<HTML><HEAD><TITLE>curl re-using connections with wrong client cert</TITLE><META http-equiv="Content-Type" content="text/html; charset=utf-8"></HEAD><BODY>Re-using connections with wrong client cert =========================================== Project cURL Security Advisory, August 3rd 2016 - [Permalink](https://curl.haxx.se/docs/adv_20160803B.html) VULNERABILITY ------------- libcurl did not consider client certificates when reusing TLS connections. libcurl supports reuse of established connections for subsequent requests. It does this by keeping a few previous connections "alive" in a connection pool so that a subsequent request that can use one of them instead of creating a new connection will do so. When using a client certificate for a connection that was then put into the connection pool, that connection could then wrongly get reused in a subsequent request to that same server that either didn't use a client certificate at all or that asked to use a different client certificate thus trying to tell the user that it is a different entity. This mistakenly using the wrong connection could of course lead to applications sending requests to the wrong realms of the server using authentication that it wasn't supposed to have for those operations. We are not aware of any exploit of this flaw. INFO ---- This flaw also affects the curl command line tool. The Common Vulnerabilities and Exposures (CVE) project has assigned the name CVE-2016-5420 to this issue. AFFECTED VERSIONS ----------------- This flaw is relevant for all versions of curl and libcurl that support SSL/TLS and client certificates. - Affected versions: libcurl 7.1 to and including 7.50.0 - Not affected versions: libcurl >= 7.50.1 libcurl is used by many applications, but not always advertised as such! THE SOLUTION ------------ In version 7.50.1, curl will check that re-used connections have the correct client certificate (file name) before used. A [patch for CVE-2016-5420](https://curl.haxx.se/CVE-2016-5420.patch) is available. This patch relies on the [CVE-2016-5419](https://curl.haxx.se/docs/adv_20160803A.html) patch already having been applied. --- lib/vtls/vtls.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/vtls/vtls.c b/lib/vtls/vtls.c index 33e209d..3863777 100644 --- a/lib/vtls/vtls.c +++ b/lib/vtls/vtls.c @@ -97,10 +97,11 @@ Curl_ssl_config_matches(struct ssl_config_data* data, if((data->version == needle->version) && (data->verifypeer == needle->verifypeer) && (data->verifyhost == needle->verifyhost) && safe_strequal(data->CApath, needle->CApath) && safe_strequal(data->CAfile, needle->CAfile) && + safe_strequal(data->clientcert, needle->clientcert) && safe_strequal(data->random_file, needle->random_file) && safe_strequal(data->egdsocket, needle->egdsocket) && safe_strequal(data->cipher_list, needle->cipher_list)) return TRUE; -- 2.8.1 RECOMMENDATIONS --------------- We suggest you take one of the following actions immediately, in order of preference: A - Upgrade curl and libcurl to version 7.50.1 B - Apply the patch to your version and rebuild C - Do not use client certificates TIME LINE --------- This was figured out by curl security team members during our work with the 20160803A flaw during June 2016. We contacted distros@openwall on July 31. libcurl 7.50.1 was released on August 3 2016, coordinated with the publication of this advisory. CREDITS ------- Found by the curl security team. Patch by Daniel Stenberg. Thanks a lot! -- / daniel.haxx.se </BODY></HTML>
